Validation check for main instance during restart#2649
Open
SuperStrongDinosaur wants to merge 1 commit into
Open
Validation check for main instance during restart#2649SuperStrongDinosaur wants to merge 1 commit into
SuperStrongDinosaur wants to merge 1 commit into
Conversation
SuperStrongDinosaur
force-pushed
the
cant_restart_main_instance
branch
from
7bdf234 to
d2f0e91
Compare
jemoreira
approved these changes
Jun 3, 2026
| } | ||
| CF_EXPECTF(!other_active, | ||
| "Restarting the first instance (ID: {}) is not allowed " | ||
| "while other instances are running. Restart the entire group instead.", |
Member
There was a problem hiding this comment.
what happens if the entire group is restarted while some instances are stopped? Are those instances [re]started too?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a check to determine if the target instance is the first instance in the group.
If it is the first instance, we check if there are any other active instances in the group. If so, the restart is blocked with the error message